Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt 1.x bump rustc-ap to v671 #4356

Merged

Conversation

calebcartwright
Copy link
Member

@calebcartwright calebcartwright commented Jul 29, 2020

Needed to fix broken toolstate rust-lang/rust#74812

Master was already addressed via #4354

Racer PR for the same rustc-ap bump opened racer-rust/racer#1124

@jonhoo
Copy link
Contributor

jonhoo commented Aug 3, 2020

@calebcartwright Looks like CI failed on this one?

@calebcartwright
Copy link
Member Author

Thanks @jonhoo. I'm aware, and it's a spurious issue with one of the four appveyor jobs. This happens from time to time with appveyor.

https://ci.appveyor.com/project/rust-lang-libs/rustfmt/builds/34356708

info: profile set to 'default'
info: setting default host triple to x86_64-pc-windows-gnu
info: syncing channel updates for 'nightly-x86_64-pc-windows-gnu'
error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-nightly.toml.sha256' to 'C:\Users\appveyor\.rustup\tmp\ft7u6n_mzdgt53n7_file'
error: caused by: failed to make network request
error: caused by: error sending request for url (https://static.rust-lang.org/dist/channel-rust-nightly.toml.sha256): error trying to connect: dns error: No such host is known. (os error 11001)
error: caused by: error trying to connect: dns error: No such host is known. (os error 11001)
error: caused by: dns error: No such host is known. (os error 11001)
error: caused by: No such host is known. (os error 11001)
Command exited with code 1

@Aaron1011
Copy link
Member

Is there anything else that needs to be done in order for this PR is merged? The lack of rustfmt on the latest nightlies is blocking solana-labs/solana#11326

@calebcartwright
Copy link
Member Author

Is there anything else that needs to be done in order for this PR is merged? The lack of rustfmt on the latest nightlies is blocking solana-labs/solana#11326

Not within this PR, just waiting for @topecongiro as I don't have access to release rustfmt on crates.io. More details on the steps and sequencing required when there's breaking upstream changes described in rust-lang/rust#74812 (comment)

@calebcartwright calebcartwright merged commit a88f028 into rust-lang:rustfmt-1.4.20 Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants