Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.x fix: Avoid incorrect global 'cfg_if' Symbol interning #4657

Merged
merged 1 commit into from
Jan 28, 2021
Merged

1.x fix: Avoid incorrect global 'cfg_if' Symbol interning #4657

merged 1 commit into from
Jan 28, 2021

Conversation

smklein
Copy link
Contributor

@smklein smklein commented Jan 19, 2021

Fixes #4656

@smklein smklein mentioned this pull request Jan 19, 2021
Closed
@smklein smklein changed the title fix: Avoid incorrect global 'cfg_if' Symbol interning 1.x fix: Avoid incorrect global 'cfg_if' Symbol interning Jan 19, 2021
@calebcartwright calebcartwright added this to the 1.4.33 milestone Jan 21, 2021
@calebcartwright
Copy link
Member

Thank you for the report and digging back through the history, and providing the PR to address! Will give it a review sometime over the next few days, but planning on pulling this into the next release to get the fix shipped 👍

calebcartwright
calebcartwright approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! Minor note, we should probably add these files to the skip list so that the idempotence+system tests don't unnecessarily run against each of the files in isolation, but not a big deal

@calebcartwright calebcartwright merged commit 5e14f76 into rust-lang:rustfmt-1.4.33 Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.33
Development

Successfully merging this pull request may close these issues.
2 participants
@smklein @calebcartwright