Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting help message #4812

Closed
wants to merge 1 commit into from
Closed

Adjusting help message #4812

wants to merge 1 commit into from

Conversation

murchu27
Copy link
Contributor

On stable, running with --help|-h shows information about file-lines which is a nightly-only option (#4798). This commit removes all mention of file-lines from the help message on stable.

There is room for improvement here; perhaps a new struct called, e.g., StableOptions could be added to complement the existing GetOptsOptions struct. StableOptions could have a field for each field in GetOptsOptions, with each field's value being a bool that specifies whether or not the option exists on stable. Or is this adding too much complexity?

On stable, running with `--help|-h` shows information about `file-lines`
which is a nightly-only option. This commit removes all mention of
`file-lines` from the help message on stable.

There is room for improvement here; perhaps a new struct called, e.g.,
`StableOptions` could be added to complement the existing
`GetOptsOptions` struct. `StableOptions` could have a field for each
field in `GetOptsOptions`, with each field's value being a `bool` that
specifies whether or not the option exists on stable. Or is this adding
too much complexity?
@murchu27
Copy link
Contributor Author

Can I get a bit of help with this? I'm not sure what's wrong with the failing checks. All of them (except the Windows ones) seem to have some error like the below when compiling

error[E0658]: unsizing casts to types besides slices are not allowed in const fn
   --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_ast-712.0.0/src/ptr.rs:136:37
    |
136 |                 std::mem::transmute(NonNull::<[T; 0]>::dangling() as NonNull<[T]>)
    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #64992 <https://github.com/rust-lang/rust/issues/64992> for more information
    = help: add `#![feature(const_fn_unsize)]` to the crate attributes to enable

error: aborting due to previous error

What can I do about this?

@calebcartwright
Copy link
Member

What can I do about this?

So sorry @murchu27, this slipped past me in my notification inbox somehow. You should be able to rebase on the master branch of this repository to resolve (just be sure to reference the upstream or whatever remote name you used for this, since we've subsequently changed the master branch to contain the same 1.x version of the code you were working with, refs #4801)

@murchu27
Copy link
Contributor Author

Thanks @calebcartwright. I'll rebase and raise a new PR. Will I merge into the master branch here, or stick with rustfmt-1.4.37?

@murchu27 murchu27 closed this Jun 10, 2021
@murchu27 murchu27 mentioned this pull request Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants