Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix const param defaults being yeeted out of code #4819

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Fix const param defaults being yeeted out of code #4819

merged 1 commit into from
Jun 10, 2021

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Apr 28, 2021

Fixes #4816

@calebcartwright calebcartwright changed the base branch from master to rustfmt-2.0.0-rc.2 April 30, 2021 00:31
@BoxyUwU BoxyUwU force-pushed the unyeetify-const-param-defaults branch from 3c9a4fb to 6479c28 Compare May 1, 2021 15:03
@calebcartwright
Copy link
Member

closed/reopened as the GitHub UI was being buggy about the workflow runs

calebcartwright
calebcartwright approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks so much!

No ETA on release yet, as we recently modified the way rustfmt gets pulled into r-l/rust for releases and it's been behaving rather difficultly this week. I'll grab the corresponding commit so it's incorporated in the next sync though

@calebcartwright calebcartwright added 1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release and removed pr-not-reviewed labels Jun 10, 2021
@calebcartwright
Copy link
Member

CI failures are unrelated (wrong toolchain, old issue)

@calebcartwright calebcartwright merged commit 2b3ca99 into rust-lang:rustfmt-2.0.0-rc.2 Jun 10, 2021
@BoxyUwU
Copy link
Member Author

BoxyUwU commented Jun 10, 2021

awesome!! thanks for reviewing :) 🎉

@karyon
Copy link
Contributor

karyon commented Oct 25, 2021

This was backported in #4925

@karyon karyon added 1x-backport:completed and removed 1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release labels Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
1x-backport:completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rustfmt yeets const param defaults
3 participants
@BoxyUwU @calebcartwright @karyon