fixes #5234 #5235
Closed
fixes #5234 #5235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @andrewgazelka, thanks for taking the time to work on this PR, and for your first contribution to rustfmt!! Just want to acknowledge that I've seen this and I'll try to do a thorough review soon. |
|
@calebcartwright thanks for pointing that out. When I have a chance to review this PR I'll make sure to take a look at those links! |
|
@ytmimi is this one you were still planning on taking a look at? if so feel free to assign to yourself (will be a helpful indicator for me 😄) |
This was referenced Nov 19, 2022
|
Thanks again for opening this PR, but going to close this in favor of #5601, which has a simpler implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5234
This will also change
to
where
'''represents backticks