Fix issue where cargo fmt --version would not display version info
#5396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes 5395 In PR 5239 we switched from using `structopt` to `clap`. It seems that the default behavior for `clap` is to override the `--version` flag, which prevented our custom version display code from running. The fix as outlined in clap-rs/clap#3405 was to set `#[clap(global_setting(AppSettings::NoAutoVersion))]` to prevent clap from setting its own default behavior for the `--version` flag.
|
Note: We have a test that likely would have caught this issue but we're currently skipping it because of issues with some of our tests when they're run in rustfmt/tests/cargo-fmt/main.rs Lines 50 to 57 in 2c8b3be |
calebcartwright
approved these changes
Jun 22, 2022
calebcartwright
added
release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5395
In PR #5239 we switched from using
structopttoclap. It seems that the default behavior forclapis to override the--versionflag, which prevented our custom version display code from running.The fix as outlined in clap-rs/clap#3405 was to set
#[clap(global_setting(AppSettings::NoAutoVersion))]to prevent clap from setting its own default behavior for the--versionflag.