-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lists doc comments fix4041 #5560
Lists doc comments fix4041 #5560
Conversation
tests/config/issue-4041.toml
Outdated
@@ -0,0 +1 @@ | |||
wrap_comments=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this file is necessary.
I would use a comment like //rustfmt-wrap_comments: true
. The reason why wrap_comments=true
isn't having any affect in the target file is because no line exceeds the default max width of 100 characters. I think we should add a tests/source/issue-4041.rs
that is unformatted and has +
lines that exceed 100 chars long.
Thanks for your first contribution to rustfmt 🎉 Take a look at the advice I gave about adding a test case that will utilize the |
Changed the test and added the source file. |
The updated test looks exactly like we want! I'm just now noticing that the doc comment on |
updated the doc comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your help on this issue and for applying all the feedback 😁 If you're interested in taking on any other issues and need help don't hesitate to reach out!
I'm going to label this as ready to merge, but I'll hold off on actually merging as we're waiting for a few PRs to land in the rust-lang/rust
repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes #4041