Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong indentation on inner attribute #6148

Merged
merged 9 commits into from
Apr 26, 2024
Merged

Fix wrong indentation on inner attribute #6148

merged 9 commits into from
Apr 26, 2024

Conversation

FwP-IDN
Copy link
Contributor

@FwP-IDN FwP-IDN commented Apr 13, 2024

close #6147

@FwP-IDN FwP-IDN changed the title fix the logic Fix wrong indentation on inner attribute Apr 13, 2024
ytmimi
ytmimi requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help on this one! Just a few minor notes.

tests/target/issue-6147/expect_not_changed.rs Outdated Show resolved Hide resolved
src/matches.rs Outdated Show resolved Hide resolved
@FwP-IDN FwP-IDN requested a review from ytmimi April 17, 2024 12:07
ytmimi
ytmimi requested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for version gating the fix and for adding the v1 test cases. One minor change before I think we're good to go on this one.

src/matches.rs Outdated Show resolved Hide resolved
FwP-IDN and others added 2 commits April 25, 2024 10:28
@FwP-IDN FwP-IDN requested a review from ytmimi April 25, 2024 03:32
ytmimi
ytmimi approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help!

@ytmimi ytmimi merged commit f781b1b into rust-lang:master Apr 26, 2024
27 checks passed
@ytmimi ytmimi added release-notes Needs an associated changelog entry and removed pr-waiting-on-author labels Apr 26, 2024
@ytmimi ytmimi mentioned this pull request Jul 6, 2024
Open
@ytmimi ytmimi removed the release-notes Needs an associated changelog entry label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytmimi ytmimi ytmimi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong shape used when rewriting inner attributes in match expression
3 participants
@FwP-IDN @ytmimi @rustbot