Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: rustfmt should not remove inner attributes from inline const blocks #6173

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Fix: rustfmt should not remove inner attributes from inline const blocks #6173

merged 1 commit into from
Jun 1, 2024

Conversation

WeiTheShinobi
Copy link
Contributor

fixes #6158

cargo test 0 failed

first time contributed on this project🥳

@ytmimi ytmimi changed the title Fix: rustfmt should not eats attributes in inline const blogs Fix: rustfmt should not eats attributes in inline const blocks May 23, 2024
@ytmimi ytmimi changed the title Fix: rustfmt should not eats attributes in inline const blocks Fix: rustfmt should not remove inner attributes from inline const blocks May 23, 2024
ytmimi
ytmimi requested changes May 24, 2024
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping in to work on this PR! With a few minor tweaks we should be good

src/expr.rs Outdated Show resolved Hide resolved
src/expr.rs Outdated Show resolved Hide resolved
@WeiTheShinobi
Copy link
Contributor Author

WeiTheShinobi commented May 24, 2024 •
edited
Loading

Looks so pretty, I'm learned a lot.
Thank you!
I will do better in the next PR.

@WeiTheShinobi WeiTheShinobi requested a review from ytmimi May 24, 2024 17:09
ytmimi
ytmimi approved these changes Jun 1, 2024
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the requested changes!

@ytmimi
Copy link
Contributor

ytmimi commented Jun 1, 2024

Diff check job also passed so we're good to go 👍🏼

@ytmimi ytmimi merged commit bf7bb56 into rust-lang:master Jun 1, 2024
27 checks passed
@ytmimi ytmimi added release-notes Needs an associated changelog entry and removed pr-ready-to-merge labels Jun 1, 2024
@WeiTheShinobi WeiTheShinobi deleted the issue_6158 branch June 10, 2024 05:46
@ytmimi ytmimi removed the release-notes Needs an associated changelog entry label Jul 6, 2024
@ytmimi ytmimi mentioned this pull request Sep 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytmimi ytmimi ytmimi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rustfmt removes inner attributes from inline const blocks
3 participants
@WeiTheShinobi @ytmimi @rustbot