unify format_string and format_file #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -189,6 +189,8 @@ fn execute() -> i32 { | |||
| // write_mode is always Plain for Stdin. | |||
| config.write_mode = WriteMode::Plain; | |||
|
|
|||
| config.skip_children = true; | |||
There was a problem hiding this comment.
This is just a wishful thinking. At the moment if you format text from stdin, and it contains mod foo;, you get a panic from a parser.
|
This looks good to me. Since @nrc is reviewing another IO PR and these may potentially conflict, I'll leave the final review to him. |
matklad
force-pushed
the
more-unification
branch
from
6548e49 to
f399668
Compare
matklad
force-pushed
the
more-unification
branch
from
f399668 to
dc1fc4b
Compare
|
Good to know! I've remove the source of potential conflict. It was a sort of dead code anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more refactoring :)