Add lsp command to fix rust-analyzer #1026
Merged
+141
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jackos
force-pushed
the
rust-analyzer-fix
branch
2 times, most recently
from
843e6fd
to
5719902
Compare
jackos
force-pushed
the
rust-analyzer-fix
branch
from
4cb307d
to
dc19b1a
Compare
Thanks for that, I squashed in the changes |
jackos
force-pushed
the
rust-analyzer-fix
branch
from
dc19b1a
to
be87cc9
Compare
|
@all-contributors please add @jackos for code |
|
@diannasoreil I've put up a pull request to add @jackos! 🎉 |
dmoore04
pushed a commit
to dmoore04/rustlings
that referenced
this pull request
Sep 11, 2022
Add lsp command to fix rust-analyzer
MadLittleMods
added a commit
to MadLittleMods/rustlings
that referenced
this pull request
Oct 14, 2024
…e repo directly > Yes, you are right, if you just clone the repository and try to edit the exercises, the language server will not work. This is one downside of the current approach. But this only affects developing exercises. > > The new method of doing Rustlings is to install Rustlings using `cargo install rustlings` (not published yet), then running `rustlings init`. No repo cloning happens. Instead, the directory `rustlings/` will be created where you find the exercises. The language server works there out of the box :) > > I need to add a warning when people try to work on the exercises from the repository. Thanks pointing this out. > > -- @mo8it, rust-lang#1935 (comment) Other references: - Previous `rustlings lsp` command: rust-lang#1026 - The changelog says "LSP support out of the box", https://github.com/rust-lang/rustlings/blob/main/CHANGELOG.md#lsp-support-out-of-the-box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is continuing from #911, as requested I've moved functionality into a subcommand that can be run like
rustings lspand added documentation plus added it to the initial welcome message.This will ensure a good developer experience for newcomers to the Rust ecosystem.