Refactor hints #231
Merged
Refactor hints #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 11, 2019 15:46
BREAKING CHANGE: This changes the way you use `rustlings run` by now requiring an abridged form of the previous filename, e.g: `rustlings run exercises/if/if1.rs` becomes `rustlings run if1`
Hints are now accessible using the CLI subcommand `rustlings hint <exercise name`. BREAKING CHANGE: This fundamentally changes the way people interact with exercises.
bors
added
S-waiting-on-bors
S-waiting-on-author
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 795b6e3 has been approved by |
bors
added
S-waiting-on-bors
and removed
S-waiting-on-author
|
@bors r- |
bors
added
S-waiting-on-author
|
Also closes #203. |
jrvidal
reviewed
Nov 11, 2019
|
|
||
| let exercise = exercises.iter().find(matching_exercise).unwrap_or_else(|| { | ||
| println!("No exercise found for your file name!"); | ||
| println!("No exercise found for your given name!"); |
There was a problem hiding this comment.
Now that we rely on exercise names, I wonder whether there should be a test to check that exercise names are unique.
There was a problem hiding this comment.
Probably, but it'd be out of scope for this PR
|
@bors r+ |
|
📌 Commit 1a7bb5a has been approved by |
bors
added
S-waiting-on-bors
and removed
S-waiting-on-author
|
@bors r- |
|
⌛ Testing commit 1a7bb5a with merge fdf6a13b66c9bd3fe067969600f9b5d0a74169f3... |
bors
added
S-waiting-on-author
|
@bors r=jrvidal |
|
📌 Commit 1a7bb5a has been approved by |
bors
added
S-waiting-on-bors
and removed
S-waiting-on-author
bors
added a commit
that referenced
this pull request
Nov 11, 2019
Refactor hints Breaking change. This removes hints from the end of files, and puts them into `info.toml`. You can now access hints using: ``` rustlings hint <exerciseName> ``` ALSO this changes the exercise system to index by name for `run` and `hint`, so: ``` rustlings run exercises/if/if1.rs ``` becomes ``` rustlings run if1 ```
|
☀️ Test successful - checks-travis |
pedantic79
pushed a commit
to pedantic79/rustlings
that referenced
this pull request
Apr 11, 2020
Refactor hints Breaking change. This removes hints from the end of files, and puts them into `info.toml`. You can now access hints using: ``` rustlings hint <exerciseName> ``` ALSO this changes the exercise system to index by name for `run` and `hint`, so: ``` rustlings run exercises/if/if1.rs ``` becomes ``` rustlings run if1 ```
ppp3
pushed a commit
to ppp3/rustlings
that referenced
this pull request
May 23, 2022
Refactor hints Breaking change. This removes hints from the end of files, and puts them into `info.toml`. You can now access hints using: ``` rustlings hint <exerciseName> ``` ALSO this changes the exercise system to index by name for `run` and `hint`, so: ``` rustlings run exercises/if/if1.rs ``` becomes ``` rustlings run if1 ```
dmoore04
pushed a commit
to dmoore04/rustlings
that referenced
this pull request
Sep 11, 2022
Refactor hints Breaking change. This removes hints from the end of files, and puts them into `info.toml`. You can now access hints using: ``` rustlings hint <exerciseName> ``` ALSO this changes the exercise system to index by name for `run` and `hint`, so: ``` rustlings run exercises/if/if1.rs ``` becomes ``` rustlings run if1 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change. This removes hints from the end of files, and puts them into
info.toml. You can now access hints using:ALSO this changes the exercise system to index by name for
runandhint, so:becomes