Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add gitpod support #473

Merged
merged 39 commits into from
Jul 23, 2020
Merged

feat: Add gitpod support #473

merged 39 commits into from
Jul 23, 2020

Conversation

ryanpcmcquen
Copy link
Contributor

We could also add a link to the browser section if the repl.it version gets merged.

@ryanpcmcquen
Add .gitpod.yml.
85eb74c
@ryanpcmcquen
Add Dockerfile.
f5eee69
@ryanpcmcquen
No user needed.
76ecead
@ryanpcmcquen
Fix path to install.
b61afcb
@ryanpcmcquen
Where is it??
f1cdf59
@ryanpcmcquen
Strange ...
e7dda24
@ryanpcmcquen
Switch to GitPod image.
e8492e8
@ryanpcmcquen
Find install file.
90604a5
@ryanpcmcquen
Where are you?
42bb26a
@ryanpcmcquen
Simplify.
cca4102
@ryanpcmcquen
Add install command here instead.
09aad5e
@ryanpcmcquen
Separate commands.
fce4a9b
@ryanpcmcquen
Use rustup.
007c097
@ryanpcmcquen
Add -y flag.
e74fb0b
@ryanpcmcquen
Save file so we can pass arguments.
75bf123
@ryanpcmcquen
Specify file name.
54c6dd6
@ryanpcmcquen
Apparently rust is in /usr/local/cargo/bin.
d94df7b
@ryanpcmcquen
Modify PATH to include installed rust.
26d65fd
@ryanpcmcquen
Move PATH export.
8113ef5
@ryanpcmcquen
Ensure new shells get the full PATH.
6dcd5eb
@ryanpcmcquen
Add gp command for setting PATH.
e78fe4e
@ryanpcmcquen
Eval is great.
6c78672
@ryanpcmcquen
Why do they both need evals?
6765a5a
@ryanpcmcquen
This should work.
09bef69
@ryanpcmcquen
Change execution path.
ad0582a
@ryanpcmcquen
Fix install path.
48e3e68
@ryanpcmcquen
Always eval.
8ae9025
@ryanpcmcquen
Move PATH.
f29a79e
@ryanpcmcquen
Add PATH here again.
4e9b9b9
@ryanpcmcquen
Move PATH to Dockerfile.
9b9601f
@ryanpcmcquen
Copy link
Contributor Author

Here's the markdown for the Gitpod badge:
[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/#https://github.com/rust-lang/rustlings)

shadows-withal
shadows-withal reviewed Jul 23, 2020
View reviewed changes
Copy link
Member

@shadows-withal shadows-withal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we usually indent YAML files with 2 spaces instead of 4. Could you change that?

@ryanpcmcquen
Copy link
Contributor Author

@fmoko, thanks, fixed!

@shadows-withal shadows-withal changed the title Add gitpod support. feat: Add gitpod support Jul 23, 2020
@shadows-withal shadows-withal merged commit 4821a8b into rust-lang:main Jul 23, 2020
aakshintala pushed a commit to aakshintala/rustlings that referenced this pull request Jul 26, 2020
@ryanpcmcquen @aakshintala
feat: Add gitpod support (rust-lang#473)
da4dbfc
ShakMR pushed a commit to ShakMR/rustlings that referenced this pull request Aug 18, 2020
@ryanpcmcquen @ShakMR
feat: Add gitpod support (rust-lang#473)
585bd8d
OnunPereira pushed a commit to OnunPereira/rustlings that referenced this pull request Sep 30, 2020
@ryanpcmcquen
feat: Add gitpod support (rust-lang#473)
145f5a0
palako pushed a commit to palako/rustlings that referenced this pull request Nov 8, 2020
@ryanpcmcquen
feat: Add gitpod support (rust-lang#473)
a9b8824
noiffion pushed a commit to noiffion/rustlings that referenced this pull request Aug 20, 2021
@ryanpcmcquen @noiffion
feat: Add gitpod support (rust-lang#473)
3f363bc
bugaolengdeyuxiaoer pushed a commit to bugaolengdeyuxiaoer/rustlings that referenced this pull request Dec 28, 2021
@ryanpcmcquen
feat: Add gitpod support (rust-lang#473)
fbb4415
ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022
feat: Add gitpod support (rust-lang#473)
5acdd2f
dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022
@ryanpcmcquen
feat: Add gitpod support (rust-lang#473)
f8523c1
Spacebody pushed a commit to Spacebody/my-rustlings that referenced this pull request Nov 18, 2022
@ryanpcmcquen @Spacebody
feat: Add gitpod support (rust-lang#473)
8670742
lziegler pushed a commit to lziegler/rustlings that referenced this pull request Dec 5, 2023
@ryanpcmcquen @lziegler
feat: Add gitpod support (rust-lang#473)
842cf45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadows-withal shadows-withal shadows-withal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanpcmcquen @shadows-withal