Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow +toolchain for rustup #1498

Closed
tbu- opened this issue Sep 4, 2018 · 6 comments · Fixed by #2031
Closed

Allow +toolchain for rustup #1498

tbu- opened this issue Sep 4, 2018 · 6 comments · Fixed by #2031

Comments

@tbu-
Copy link
Contributor

tbu- commented Sep 4, 2018

It was surprising to me that I couldn't use the +nightly parameter on rustup for adding the wasm32-unknown-unknown target to nightly:

rustup +nightly target add wasm32-unknown-unknown

(and other combinations didn't work either). Instead I had to find the --toolchain parameter of rustup target add. It would be nice if +nightly would work on rustup, too.

@tbu-
Copy link
Contributor Author

tbu- commented Sep 4, 2018

CC #1489.

@vi
Copy link

vi commented Sep 12, 2018

In addition to +nightly all of theese should also work:

  • rustup --toolchain=nightly target add wasm32-unknown-unknown
  • rustup target --toolchain=nightly add wasm32-unknown-unknown

Also rustup target --help should mention --toolchain somewhere.

@pickfire
Copy link
Contributor

pickfire commented Oct 2, 2019

I would like to do this. I noticed that cargo does not explicitly parse this but instead passes this to rustc to handle it. Should we check it on rustup side with internal function to list toolchains?

@BeniCheni
Copy link
Contributor

Hi @pickfire, friendly note that from this comment from #1489, I started working on the 2nd PR for +foo variant in the same scope of #2031. Should be able to push an update later today for +foo variant.

@pickfire
Copy link
Contributor

pickfire commented Oct 3, 2019

@BeniCheni Yeah, but that's just for which right? I want to help out on this too.

@BeniCheni
Copy link
Contributor

BeniCheni commented Oct 3, 2019

@pickfire, from this comment from #1489:

and then have #1498 provide the +foo variant.

I'm interested in trying out. ...

From my comment there, I indicated my interest in working on #1498 here. But I'm happy to share, if you want to try out a PR for #1498 here.

Let me know if you are committed to this issue. If yes, I can check out other open issues. If no, I will continue to pick up this issue, since #2031 is in final shape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants