Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated dependent crates #1755

Closed
3 tasks done
tesuji opened this issue Apr 11, 2019 · 1 comment · Fixed by #1759
Closed
3 tasks done

Replace deprecated dependent crates #1755

tesuji opened this issue Apr 11, 2019 · 1 comment · Fixed by #1759

Comments

@tesuji
Copy link
Contributor

tesuji commented Apr 11, 2019

Describe the problem you are trying to solve

I suggest to replace deprecated (abandoned) dependent crates like:

  • markdown => pulldown_cmark
    Rationale: rustup currently needs to iterate through markdown::Block
    to print content to std{out,err} approriately. But pulldown_cmark
    doesn't provide equivalent methods (only push_html and write_html).

  • ole32-sys => winapi
    Rationale: I remove ole32-sys from Cargo.toml and rustup build fine.

  • time => chrono
    Rationale: chrono currently use time as dependency itself.

Describe the solution you'd like

Just try to replace them. Build and fix cycle :) .

Notes

Nothing here.

@kinnison
Copy link
Contributor

This sounds emminently sensible and I look forward to reviewing PRs for each in turn :D

@tesuji tesuji changed the title Replace deprecated crates Replace deprecated dependent crates Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants