Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up dependency and code base #1759

Merged
merged 8 commits into from
Apr 19, 2019
Merged

Clean up dependency and code base #1759

merged 8 commits into from
Apr 19, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Apr 13, 2019 •
edited
Loading

This pull request:

  • Remove unused dep: ole32-sys
  • Remove unused dep: itertools
  • Remove global allocator
  • Make truly random string
  • Sort deps according to alphabet order
  • perf: Use lazy_static with regex

Closes #1755.

@tesuji tesuji mentioned this pull request Apr 13, 2019
Closed
@bors
Copy link
Contributor

bors commented Apr 14, 2019

☔ The latest upstream changes (presumably #1744) made this pull request unmergeable. Please resolve the merge conflicts.

nrc
nrc reviewed Apr 14, 2019
View reviewed changes
Copy link
Member

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions inline. Thanks for the PR!

src/cli/help.rs Outdated Show resolved Hide resolved
src/cli/self_update.rs Show resolved Hide resolved
src/cli/self_update.rs Outdated Show resolved Hide resolved
@tesuji tesuji force-pushed the unused-deps branch 3 times, most recently from e19438a to 9a199a1 Compare April 14, 2019 05:41
@kinnison
Copy link
Contributor

Mostly LGTM but needs nick's comments resolving.

@bors
Copy link
Contributor

bors commented Apr 14, 2019

☔ The latest upstream changes (presumably #1754) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Apr 14, 2019

☔ The latest upstream changes (presumably #1764) made this pull request unmergeable. Please resolve the merge conflicts.

@tesuji tesuji force-pushed the unused-deps branch 2 times, most recently from 0158a82 to f435160 Compare April 15, 2019 02:49
@bors
Copy link
Contributor

bors commented Apr 16, 2019

☔ The latest upstream changes (presumably #1769) made this pull request unmergeable. Please resolve the merge conflicts.

@tesuji tesuji force-pushed the unused-deps branch 3 times, most recently from 7f62906 to 0db046d Compare April 16, 2019 21:34
@tesuji
Copy link
Contributor Author

tesuji commented Apr 19, 2019

Is there anything I can do to improve this pull request?

kinnison
kinnison approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A final pass and this LGTM. Thank you for the libc::c_char fix, since I was about to have to do that myself :D

@kinnison kinnison merged commit 126913d into rust-lang:master Apr 19, 2019
@tesuji tesuji deleted the unused-deps branch April 19, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrc nrc nrc left review comments

@retep998 retep998 retep998 left review comments

@kinnison kinnison kinnison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace deprecated dependent crates
5 participants
@tesuji @bors @kinnison @retep998 @nrc