RISC-V support? #2296

tommythorn · 2020-04-24T15:57:53Z

Describe the problem you are trying to solve
rustup is wonderful, so it's sad it doesn't support RISC-V, I get "rustup: unknown CPU type: riscv64" which run on Ubuntu 20.04 (which has rustc, cargo, etc).

Describe the solution you'd like
I'd like it to install the latest Rust

Notes
I used the Ubuntu image from https://github.com/carlosedp/riscv-bringup to issue the commands. I assume this is actually blocked on something on rust side, but I didn't see any issues tracking this.

tesuji · 2020-04-25T02:43:47Z

One could investigate and add risv cpu type to

rustup/rustup-init.sh

Lines 228 to 296 in c022b92

    
           case "$_cputype" in 
        
               i386 | i486 | i686 | i786 | x86) 
        
                   _cputype=i686 
        
                   ;; 
        
               xscale | arm) 
        
                   _cputype=arm 
        
                   if [ "$_ostype" = "linux-android" ]; then 
        
                       _ostype=linux-androideabi 
        
                   fi 
        
                   ;; 
        
               armv6l) 
        
                   _cputype=arm 
        
                   if [ "$_ostype" = "linux-android" ]; then 
        
                       _ostype=linux-androideabi 
        
                   else 
        
                       _ostype="${_ostype}eabihf" 
        
                   fi 
        
                   ;; 
        
               armv7l | armv8l) 
        
                   _cputype=armv7 
        
                   if [ "$_ostype" = "linux-android" ]; then 
        
                       _ostype=linux-androideabi 
        
                   else 
        
                       _ostype="${_ostype}eabihf" 
        
                   fi 
        
                   ;; 
        
               aarch64) 
        
                   _cputype=aarch64 
        
                   ;; 
        
               x86_64 | x86-64 | x64 | amd64) 
        
                   _cputype=x86_64 
        
                   ;; 
        
               mips) 
        
                   _cputype=$(get_endianness mips '' el) 
        
                   ;; 
        
               mips64) 
        
                   if [ "$_bitness" -eq 64 ]; then 
        
                       # only n64 ABI is supported for now 
        
                       _ostype="${_ostype}abi64" 
        
                       _cputype=$(get_endianness mips64 '' el) 
        
                   fi 
        
                   ;; 
        
               ppc) 
        
                   _cputype=powerpc 
        
                   ;; 
        
               ppc64) 
        
                   _cputype=powerpc64 
        
                   ;; 
        
               ppc64le) 
        
                   _cputype=powerpc64le 
        
                   ;; 
        
               s390x) 
        
                   _cputype=s390x 
        
                   ;; 
        
               *) 
        
                   err "unknown CPU type: $_cputype"

tommythorn · 2020-04-25T04:24:21Z

Hmm, tried the obvious

--- rustup.sh.org	2020-04-01 17:52:18.571954138 +0000
+++ rustup.sh	2020-04-01 17:34:57.396790022 +0000
@@ -226,6 +226,9 @@
     esac
 
     case "$_cputype" in
+	riscv64)
+	    _cputype=riscv64
+	    ;;
 
         i386 | i486 | i686 | i786 | x86)
             _cputype=i686

but assuming this follows the convention, the failure is

rustup: command failed: downloader https://static.rust-lang.org/rustup/dist/riscv64-unknown-linux-gnu/rustup-init /tmp/tmp.jnFi5770CM/rustup-init

tesuji · 2020-04-25T04:26:50Z

What is the full target triple of riscv?

tesuji · 2020-04-25T04:28:46Z

Does riscv has std? rustup depends on std.
Acording to https://forge.rust-lang.org/release/platform-support.html, riscv is bare metal
only.

tommythorn · 2020-04-25T05:41:19Z

I don't know what the convention calls for but poking around I found:

tommy@Ubuntu-riscv64:~$ rustc --print target-list|grep riscv
riscv32i-unknown-none-elf
riscv32imac-unknown-none-elf
riscv32imc-unknown-none-elf
riscv64gc-unknown-linux-gnu
riscv64gc-unknown-none-elf
riscv64imac-unknown-none-elf

I don't know how Canonical got their riscv rust binaries.

tommythorn · 2020-04-25T05:44:29Z

Changing the _cputype=riscv64gc I get

info: downloading installer
curl: (22) The requested URL returned error: 404 
rustup: command failed: downloader https://static.rust-lang.org/rustup/dist/riscv64gc-unknown-linux-gnu/rustup-init /tmp/tmp.PxoInJ2fwo/rustup-init

kinnison · 2020-04-26T19:34:35Z

There are multiple things at play here.

rustup-init.sh needs to know about riscv
rustup itself needs to be taught because otherwise it can't recognise it for toolchains (targets are a different matter)
rust-lang/rust needs to publish dockers for building targetting riscv
our CI needs updating to include riscv as a target
rust-lang/rust needs to publish a riscv toolchain, not just a std
and finally we can do a release of rustup including riscv linux

If people are serious about assisting with this, then perhaps we might put together a checklist and get it underway; though without support from the main rust-lang/rust repo for the docker and the compiler releases, there's not a lot we can do beyond preparing for the possiblity in the future.

tommythorn · 2020-04-27T16:56:57Z

Thanks, it was exactly a list like this I was hoping to see. Without a published toolchain there's not much point to the rest. IIUC, this is tracked by rust-lang/rust#62117 which I updated to point back here.

tblah · 2020-04-28T13:19:20Z

I have a WIP PR for this #2313

It isn't useful yet because there aren't official toolchains for a riscv host. However cross-compilation toolchains can be downloaded for a riscv target today (tested using rustup 1.21.1): see cross-rs/cross#413

kinnison · 2020-07-06T18:03:07Z

The completed riscvgc support was released today. I'd be interested to know if it works for you or not.

tommythorn · 2020-07-06T19:14:18Z

Thanks! The script seems to progress on my (fully up-to-date) Ubuntu RISC-V VM. However, it looks like we aren't there yet:

Current installation options:


   default host triple: riscv64gc-unknown-linux-gnu
     default toolchain: stable (default)
               profile: default
  modify PATH variable: yes

1) Proceed with installation (default)
2) Customize installation
3) Cancel installation
>1

info: profile set to 'default'
info: default host triple is riscv64gc-unknown-linux-gnu
info: syncing channel updates for 'stable-riscv64gc-unknown-linux-gnu'
info: latest update on 2020-06-18, rust version 1.44.1 (c7087fe00 2020-06-17)
error: target 'riscv64gc-unknown-linux-gnu' not found in channel.  Perhaps check https://forge.rust-lang.org/release/platform-support.html for available targets

riscv64gc-unknown-linux-gnu is listed under Tier 2 (does that imply not-stable?).

tommythorn · 2020-07-06T19:16:14Z

Taking option 2 and picking nightly didn't help:

Current installation options:


   default host triple: riscv64gc-unknown-linux-gnu
     default toolchain: nightly
               profile: default
  modify PATH variable: no

1) Proceed with installation (default)
2) Customize installation
3) Cancel installation
>1

info: profile set to 'default'
info: setting default host triple to riscv64gc-unknown-linux-gnu
info: syncing channel updates for 'nightly-riscv64gc-unknown-linux-gnu'
info: latest update on 2020-07-06, rust version 1.46.0-nightly (2753fab7c 2020-07-05)
error: target 'riscv64gc-unknown-linux-gnu' not found in channel.  Perhaps check https://forge.rust-lang.org/release/platform-support.html for available targets

kinnison · 2020-07-06T19:46:47Z

Okay so we're closer but still no cigar. @tblah Is this what you'd expect for now?

mati865 · 2020-07-06T20:08:10Z

Rustup for RISC-V won't work until rust-lang/rust#72973 is merged.

kinnison · 2020-07-06T21:18:54Z

Thanks for that @mati865

tblah · 2020-07-07T08:19:23Z

@tommythorn currently RISC-V is Tier 2 only for cross compilation. But as @mati865 said that may soon change to full support.

rust-lang/rust#72973 is waiting for rust-lang/compiler-team#312 to be approved. If there are no objections that could happen about 2 days from now.

After that rustup may need changing to point at the CI pipeline introduced in rust-lang/rust#72973

kinnison · 2020-07-07T08:34:31Z

@tblah By 'need changing' do you mean for the CI, or a point release being needed to use it?

tblah · 2020-07-07T08:39:15Z

@kinnison just CI if I understand correctly.

rust-lang/rust#72973 moves the RISC-V build to a new docker image so rustup needs to use that image too here

kinnison · 2020-07-07T08:51:38Z

I'll make sure to be subscribed to that PR then, though I hope one of the contributors here might get to PRing our CI before me :D

tommythorn · 2020-09-29T19:15:08Z

I'm afraid I lost track of where this is at.

I can see that rust-lang/rust#72973 was merged, rust-lang/compiler-team#312 was closed, and riscv64gc-unknown-linux-gnu is AFAICT listed as a supported platform in Tier 2 "riscv64gc-unknown-linux-gnu | ✓ | ✓ | RISC-V Linux (kernel 4.20, glibc 2.29) -- | -- | -- | --"

Launching rustup.sh (from https://sh.rustup.rs) in a Fedora RISC-V QEMU image leads to

...
info: profile set to 'default'
info: default host triple is riscv64gc-unknown-linux-gnu
info: syncing channel updates for 'stable-riscv64gc-unknown-linux-gnu'
info: latest update on 2020-08-27, rust version 1.46.0 (04488afe3 2020-08-24)
error: target 'riscv64gc-unknown-linux-gnu' not found in channel.  Perhaps check https://forge.rust-lang.org/release/platform-support.html for available targets

I wasn't immediately able to find out where rustup-init was reading (the manifest? from whence?) and not finding it.

tesuji · 2020-09-30T02:12:56Z

If it is host toolchain, we have to have riscv build for rustup, then wait until next rustup release.

tommythorn · 2020-09-30T03:58:28Z

I apologize for my ignorance. I poked around some more and discovered that there are indeed nightly builds for RISC-V and lo and behold rustup.sh --default-toolchain nightly worked, thus as far as I'm concerned this issue can be closed. Thank you!

tommythorn · 2020-09-30T17:50:17Z

Ok, no objections. Closing.

tommythorn added the enhancement label Apr 24, 2020

tommythorn mentioned this issue Apr 27, 2020

Support riscv64gc-unknown-linux-gnu target rust-lang/rust#62117

Closed

rust-lang deleted a comment Jun 1, 2020

rust-lang deleted a comment from tesuji Jun 1, 2020

tommythorn closed this as completed Sep 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RISC-V support? #2296

RISC-V support? #2296

tommythorn commented Apr 24, 2020

tesuji commented Apr 25, 2020

tommythorn commented Apr 25, 2020

tesuji commented Apr 25, 2020

tesuji commented Apr 25, 2020

tommythorn commented Apr 25, 2020

tommythorn commented Apr 25, 2020

kinnison commented Apr 26, 2020

tommythorn commented Apr 27, 2020

tblah commented Apr 28, 2020 •

edited

Loading

kinnison commented Jul 6, 2020

tommythorn commented Jul 6, 2020

tommythorn commented Jul 6, 2020

kinnison commented Jul 6, 2020

mati865 commented Jul 6, 2020

kinnison commented Jul 6, 2020

tblah commented Jul 7, 2020

kinnison commented Jul 7, 2020

tblah commented Jul 7, 2020

kinnison commented Jul 7, 2020

tommythorn commented Sep 29, 2020

tesuji commented Sep 30, 2020

tommythorn commented Sep 30, 2020

tommythorn commented Sep 30, 2020

RISC-V support? #2296

RISC-V support? #2296

Comments

tommythorn commented Apr 24, 2020

tesuji commented Apr 25, 2020

tommythorn commented Apr 25, 2020

tesuji commented Apr 25, 2020

tesuji commented Apr 25, 2020

tommythorn commented Apr 25, 2020

tommythorn commented Apr 25, 2020

kinnison commented Apr 26, 2020

tommythorn commented Apr 27, 2020

tblah commented Apr 28, 2020 • edited Loading

kinnison commented Jul 6, 2020

tommythorn commented Jul 6, 2020

tommythorn commented Jul 6, 2020

kinnison commented Jul 6, 2020

mati865 commented Jul 6, 2020

kinnison commented Jul 6, 2020

tblah commented Jul 7, 2020

kinnison commented Jul 7, 2020

tblah commented Jul 7, 2020

kinnison commented Jul 7, 2020

tommythorn commented Sep 29, 2020

tesuji commented Sep 30, 2020

tommythorn commented Sep 30, 2020

tommythorn commented Sep 30, 2020

tblah commented Apr 28, 2020 •

edited

Loading