Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source ~/.cargo/env in .bashrc cause a machine failed as a rsync target #498

Closed
jarod opened this issue May 25, 2016 · 2 comments
Closed

source ~/.cargo/env in .bashrc cause a machine failed as a rsync target #498

jarod opened this issue May 25, 2016 · 2 comments

Comments

@jarod
Copy link

jarod commented May 25, 2016

because of these output in ~/.cargo/env

printf "PATH environment variable set.\n"
printf "You're ready to Rust!\n\n"

$ rsync -avrpz --delete dir/ target_server:dir/
protocol version mismatch -- is your shell clean?
(see the rsync man page for an explanation)
rsync error: protocol incompatibility (code 2) at compat.c(176) [sender=3.1.1]

It took me some time to find the problem.
maybe this not even an issue of rustup, but this really cause trouble to user.
@brson
Copy link
Contributor

brson commented Jun 3, 2016

I don't quite understand what's going on here. What's causing rsync to fail?

@erickt
Copy link
Contributor

erickt commented Jun 11, 2016

Non-interactive ssh sessions can pipe binary data through stdout (like rsync), so strings being printed out during session creation can break these protocols. We should just remove those strings. Besides, as one who opens a bunch of terminals, it gets a bit noisy to announce that rust is available.

erickt added a commit to erickt/rustup.rs that referenced this issue Jun 11, 2016
@erickt
Remove printfs from ~/.cargo/env
ac08f4c 
This printout can break non-interactive shells that use ssh to
pipe binary data through stdout, like rsync. Plus it gets a bit
noisy.

Closes rust-lang#498
@erickt erickt mentioned this issue Jun 11, 2016
Merged
nodakai pushed a commit to nodakai/rustup.rs that referenced this issue Apr 23, 2017
@erickt @nodakai
Remove printfs from ~/.cargo/env
9ec844b 
This printout can break non-interactive shells that use ssh to
pipe binary data through stdout, like rsync. Plus it gets a bit
noisy.

Closes rust-lang#498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jarod @erickt @brson