Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS 2017 updates #1145

Merged
merged 2 commits into from
Jun 2, 2017
Merged

VS 2017 updates #1145

merged 2 commits into from
Jun 2, 2017

Conversation

brson
Copy link
Contributor

@brson brson commented Jun 1, 2017

Once rust-lang/rust#42225 lands rustup should build correctly under VS 2017.

r? @Diggsey

@Diggsey
Copy link
Contributor

Diggsey commented Jun 1, 2017

Not much to review here 😛

@bors r+

@bors
Copy link
Contributor

bors commented Jun 1, 2017

📌 Commit 4a62f14 has been approved by Diggsey

@bors
Copy link
Contributor

bors commented Jun 1, 2017

⌛ Testing commit 4a62f14 with merge 12ffb1c...

bors added a commit that referenced this pull request Jun 1, 2017
VS 2017 updates

Once rust-lang/rust#42225 lands rustup should build correctly under VS 2017.

r? @Diggsey
@bors
Copy link
Contributor

bors commented Jun 1, 2017

💔 Test failed - status-appveyor

@Diggsey
Copy link
Contributor

Diggsey commented Jun 1, 2017

@bors retry

@bors
Copy link
Contributor

bors commented Jun 1, 2017

⌛ Testing commit 4a62f14 with merge 3344755...

bors added a commit that referenced this pull request Jun 1, 2017
VS 2017 updates

Once rust-lang/rust#42225 lands rustup should build correctly under VS 2017.

r? @Diggsey
@bors
Copy link
Contributor

bors commented Jun 2, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: Diggsey
Pushing 3344755 to master...

@bors bors merged commit 4a62f14 into rust-lang:master Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants