Warn when tools are missing and allow to override #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a lot of refactoring here too. There was a check to ensure that if there are components that we plan to install (or update) that are missing from the manifest, then we error out. However, this only worked for components that had an entry in the manifest under the Rust package, but were missing components of their own. For tools like the RLS, when they are missing, they are completely missing from the manifest. They therefore didn't get picked up by the check. This patch adds an extra Vec to track such components and then warns about them.
|
Looks good to me! I think though that the added test may be failing? |
This adds a new test and removes test `update_removes_components_that_dont_exist` Historically, this test was added before the check that aborts update on missing components (which is tested by the new test in the previous commit, as well as elsewhere), so I think this test was only testing a bug. Note that the new behaviour is the same as the ancient behviour when the user uses `--force`
|
OK, looks like we're passing tests now (I guess Travis is stuck or got bored or something). |
|
@bors: r+ |
|
📌 Commit dcf0f9d has been approved by |
bors
added a commit
that referenced
this pull request
Jan 15, 2018
Warn when tools are missing and allow to override Closes #1277 Idea here is to not update if the RLS is missing (for example). There was actually functionality to do this already, but it was not catching the RLS and Rustfmt since they were missing in an unexpected way. The second commit adds `rustup update --force` to update even if some components are missing r? @alexcrichton
|
💥 Test timed out |
|
@bors: retry
…On Mon, Jan 15, 2018 at 7:07 PM, bors ***@***.***> wrote:
💥 Test timed out
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1337 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAD95AJYIq6XIRx0ktZbp99-FzOFfK_jks5tLBJkgaJpZM4RaSj1>
.
|
bors
added a commit
that referenced
this pull request
Jan 16, 2018
Warn when tools are missing and allow to override Closes #1277 Idea here is to not update if the RLS is missing (for example). There was actually functionality to do this already, but it was not catching the RLS and Rustfmt since they were missing in an unexpected way. The second commit adds `rustup update --force` to update even if some components are missing r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1277
Idea here is to not update if the RLS is missing (for example). There was actually functionality to do this already, but it was not catching the RLS and Rustfmt since they were missing in an unexpected way.
The second commit adds
rustup update --forceto update even if some components are missingr? @alexcrichton