Migrate browser opening logic to match Cargo #1830
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May impact #1125.
Cargo uses the opener crate for opening the user's browser. I noticed some interest in deduplicating and unifying the logic used between Rustup and Cargo in a couple places, and I think this is a reasonable part of doing that.
This PR removes about 80 lines of platform-specific code with a dependency on opener, which has no dependencies of its own. It indirectly removes an outstanding FIXME in the codebase.