Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinnison/retry downloads #2121

Merged
merged 5 commits into from
Nov 11, 2019
Merged

Kinnison/retry downloads #2121

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d8a2fb
utils: Ensure download tracker is finalised on error
kinnison Nov 11, 2019
9685a0a
utils: A download returning 416 is not treated as a client error
kinnison Nov 11, 2019
97073e0
notifications: Add RetryingDownload notification
kinnison Nov 11, 2019
76a47f7
manifestation: Retry downloads
kinnison Nov 11, 2019
e1a5fca
CONTRIBUTING: Document RUSTUP_MAX_RETRIES
kinnison Nov 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,13 @@ than 1, it is clamped to 1 at minimum.
This is not meant for use by users, but can be suggested in diagnosing an issue
should one arise with the backtrack limits.

### `RUSTUP_MAX_RETRIES`

When downloading a file, rustup will retry the download a number of times. The
default is 3 times, but if this variable is set to a valid usize then it is the
max retry count. A value of `0` means no retries, thus the default of `3` will
mean a download is tried a total of four times before failing out.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, shouldn't this go to Readme instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My hope is that noone will need to tweak this, if we decide to expose it to users then it becomes a thing we have to support long term, rather than something where in an issue we can say "Please try this and see if it helps" to help decide if we need to change the defaults.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh...

I think a valid use-case might be increasing the limit for CI (where networking can get unstable). Cargo has a knob for it in .cargo/config, [net] retries = 92.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is a place where people get even more angry if I change things. Humans seem more prepared to change their own workflows than to change CI setups which "have always worked".


### `RUSTUP_BACKTRACE`

By default while running tests, we unset some environment variables that will
Expand Down