Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links #2173

Merged
merged 3 commits into from
Dec 29, 2019
Merged

Update links #2173

merged 3 commits into from
Dec 29, 2019

Conversation

JohnTitor
Copy link
Member

Also,

documentation = "https://rust-lang.github.io/rustup.rs/rustup/index.html"

should be replaced but I'm not sure what the correct link is (https://rustup.rs?).

@kinnison
Copy link
Contributor

We don't really have rustdoc published any more for rustup because it's not a library for others to use. I'd suggest we either replace it with https://rustup.rs/ or just drop the documentation entry alltogether.

@JohnTitor
Copy link
Member Author

I feel it's meaningless nowadays so I dropped it. (offtopic: I saw your message on Discord, no rush, take care of yourself!)

Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these look good to me, Thank you!

@kinnison kinnison merged commit d6366cb into rust-lang:master Dec 29, 2019
@JohnTitor JohnTitor deleted the update-links branch December 29, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants