Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentelemetry #3526

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Update opentelemetry #3526

merged 2 commits into from
Nov 9, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 7, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
opentelemetry workspace.dependencies minor 0.20.0 -> 0.21.0
opentelemetry-otlp (source) workspace.dependencies minor 0.13.0 -> 0.14.0

Release Notes

open-telemetry/opentelemetry-rust (opentelemetry)

v0.21.0

Compare Source

This release should been seen as 1.0-rc4 following 1.0-rc3 in v0.20.0. Refer to CHANGELOG.md in individual creates for details on changes made in different creates.

Changed
  • Bump MSRV to 1.65 #​1318
  • opentelemetry crate now only carries the API types #​1186. Use the opentelemetry_sdk crate for the SDK types.
  • trace::noop::NoopSpan no longer implements Default and instead exposes a const DEFAULT value. #​1270
  • Updated crate documentation and examples. #​1256
  • Breaking SpanBuilder attributes changed from OrderMap<Key, Value> to Vec<KeyValue> and with_attributes_map method is removed from SpanBuilder. This implies that OpenTelemetry API will no longer perform de-dup of attribute Keys. #​1293. Please share feedback here, if you are affected.
open-telemetry/opentelemetry-rust (opentelemetry-otlp)

v0.14.0

Compare Source

Added
  • Add build_{signal}_exporter methods to client builders (#​1187)
  • Add grpcio metrics exporter (#​1202)
  • Allow specifying OTLP HTTP headers from env variable (#​1290)
Changed
  • Bump MSRV to 1.65 #​1318
  • Bump MSRV to 1.64 #​1203
  • Changed dependency from opentelemetry_api to opentelemetry as the latter
    is now the API crate. #​1226
  • Make NoExporterBuilder a compiling time error #​1271

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies label Nov 7, 2023
Copy link
Contributor Author

renovate bot commented Nov 7, 2023

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Cargo.lock
Command failed: docker run --rm --name=renovate_a_sidecar --label=renovate_a_child --memory=3584m -v "/tmp/worker/bb4709/c41089/repos/github/rust-lang/rustup":"/tmp/worker/bb4709/c41089/repos/github/rust-lang/rustup" -v "/tmp/worker/bb4709/c41089/cache":"/tmp/worker/bb4709/c41089/cache" -e GIT_CONFIG_KEY_0 -e GIT_CONFIG_VALUE_0 -e GIT_CONFIG_KEY_1 -e GIT_CONFIG_VALUE_1 -e GIT_CONFIG_KEY_2 -e GIT_CONFIG_VALUE_2 -e GIT_CONFIG_COUNT -e CONTAINERBASE_CACHE_DIR -w "/tmp/worker/bb4709/c41089/repos/github/rust-lang/rustup" ghcr.io/containerbase/sidecar:9.23.11 bash -l -c "install-tool rust 1.73.0 && cargo update --config net.git-fetch-with-cli=true --manifest-path Cargo.toml --workspace"
    Updating crates.io index
error: failed to select a version for `opentelemetry`.
    ... required by package `rustup v1.26.0 (/tmp/worker/bb4709/c41089/repos/github/rust-lang/rustup)`
versions that meet the requirements `^0.21.0` are: 0.21.0

the package `rustup` depends on `opentelemetry`, with features: `rt-tokio` but `opentelemetry` does not have these features.


failed to select a version for `opentelemetry` which could resolve this conflict

@rami3l rami3l self-assigned this Nov 7, 2023
Copy link
Contributor Author

renovate bot commented Nov 7, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@rami3l
Copy link
Member

rami3l commented Nov 7, 2023

Tried to migrate, but got blocked because https://crates.io/crates/tracing-opentelemetry/0.21.0 is not compatible with this update. Claim.

@rami3l rami3l marked this pull request as draft November 7, 2023 06:23
@djc
Copy link
Contributor

djc commented Nov 7, 2023

This has to wait for tokio-rs/tracing-opentelemetry#68.

@rami3l rami3l force-pushed the renovate/opentelemetry branch from 03ef983 to 40ffe28 Compare November 8, 2023 16:20
@rami3l rami3l marked this pull request as ready for review November 8, 2023 16:20
@rami3l
Copy link
Member

rami3l commented Nov 8, 2023

This has to wait for tokio-rs/tracing-opentelemetry#68.

@djc Thanks a lot! I believe it's unblocked now. It'll take me some time to get a proper fix though... Please stay tuned!

@rami3l rami3l marked this pull request as draft November 8, 2023 16:24
@rami3l rami3l force-pushed the renovate/opentelemetry branch from 40ffe28 to 150fa45 Compare November 8, 2023 16:26
@rami3l rami3l force-pushed the renovate/opentelemetry branch from 150fa45 to 9897b7d Compare November 8, 2023 16:33
@rami3l rami3l marked this pull request as ready for review November 8, 2023 16:35
@rami3l rami3l requested a review from djc November 8, 2023 16:55
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rami3l rami3l merged commit 8040fe8 into master Nov 9, 2023
21 checks passed
@rami3l rami3l deleted the renovate/opentelemetry branch November 9, 2023 14:32
@rami3l rami3l mentioned this pull request Jan 29, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants