Fix panic in component list --toolchain stable
#3548
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3547
Fixes a panic caused by the signature of the parser passed to Claps's
Arg.value_parser()
having PartialToolchainDesc, not matchingArgMatches.get_one::<ResolvableToolchainName>()
inexplicit_or_dir_toolchain()
Also, renames
explicit_or_dir_toolchain()
->explicit_desc_or_dir_toolchain()
and consolidates its use across various CLI subcommands.Also fixes a similar panic in
rustup man --toolchain stable
It seems like Clap is very type-unsafe in this regard. I made a small effort to find other similar problems by eyeball, but there's just so many subcommands to cross-reference... Probably we need to have more rigorous testing of all CLI arguments that have a
.value_parser()
.