-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(doc): don't show the opening message when --path is used #3748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Besides, your topic_name
does remind me of an edge case that I forgot to handle in #3674: rustup doc std::fs
.
Reusing this variable gives Opening docs named `std::fs` in your browser
, I guess that looks just right?
sorry, i forget to run the init command, yup every thing seams to work fine now |
This might seem like a travel or unnecessary thing, especially since the message is written to `stderr` so it won't affect piping or similar use cases. But since `stdout` and `stderr` are ambiguous in most terminals (i.e., they're printed in the output) this might cause some confusion and/or annoyance to some users.
@0x61nas Thanks again! |
This might seem like a travel or unnecessary thing, especially since the message is written to
stderr
so it won't affect piping or similar use cases.But since
stdout
andstderr
are ambiguous in most terminals (i.e., they're printed in the output) this might cause some confusion and/or annoyance to some users.