Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci/freebsd): fix invalid peer certificate: UnknownIssuer #3810

Merged
merged 1 commit into from
May 7, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented May 7, 2024

Caused by #3798, this is essentially astral-sh/uv#3369. However, we didn't choose to switch to bundled CA certs, otherwise suddenly Rustup binaries will come with an expiration date :/

https://github.com/rust-lang/rustup/actions/runs/8978258543/job/24658381207 has passed after adding pkg install -y ca_root_nss to the setup.

@rami3l rami3l force-pushed the ci/freebsd-rustls branch from b8dd32a to 727969d Compare May 7, 2024 01:30
@rami3l rami3l requested a review from djc May 7, 2024 02:33
@rami3l rami3l marked this pull request as ready for review May 7, 2024 02:33
@rami3l rami3l force-pushed the ci/freebsd-rustls branch from 727969d to 7b20004 Compare May 7, 2024 02:34
@rami3l rami3l enabled auto-merge May 7, 2024 02:35
@rami3l rami3l added this to the 1.28.0 milestone May 7, 2024
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rami3l rami3l added this pull request to the merge queue May 7, 2024
Merged via the queue into master with commit 3437f7b May 7, 2024
22 checks passed
@rami3l rami3l deleted the ci/freebsd-rustls branch May 7, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants