Add loongarch64-unknown-linux-musl support #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
reviewed
Jul 4, 2024
rami3l
reviewed
Jul 4, 2024
| - x86_64-linux-android # skip-pr skip-master | ||
| - riscv64gc-unknown-linux-gnu # skip-pr skip-master | ||
| - loongarch64-unknown-linux-gnu # skip-pr skip-master | ||
| - loongarch64-unknown-linux-musl # skip-pr skip-master skip-stable |
There was a problem hiding this comment.
Hmmm so you're saying that the CI should completely ignore this target as for now, if I'm not mistaken?
There was a problem hiding this comment.
Yes. If I'm not mistaken, rustup is currently only built with stable rustc. The first stable version of loongarch64-linux-musl will be 1.81, when skip-stable will be removed. Thanks
There was a problem hiding this comment.
@heiher I see. Thanks for the explanation!
There was a problem hiding this comment.
@heiher Are we ready for releasing this on stable now?
This should be the right time if possible, since we're releasing v1.28.0 beta very soon:
rami3l
approved these changes
Jul 5, 2024
djc
approved these changes
Jul 5, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip-stable because we're not going to release this for now