Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dist): refine suggestions regarding manifest checksum mismatches #3923

Merged
merged 5 commits into from
Jul 8, 2024
Merged

feat(dist): refine suggestions regarding manifest checksum mismatches #3923

merged 5 commits into from
Jul 8, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Jul 7, 2024 •
edited
Loading

Closes #3885.

I've made the following update to the error messages nonetheless:

Before

    info: syncing channel updates for 'nightly-aarch64-apple-darwin'
    info: update not yet available, sorry! try again later
    error: toolchain 'nightly-aarch64-apple-darwin' is not installable

After

    info: syncing channel updates for 'nightly-aarch64-apple-darwin'
    warn: checksum failed for <SNIP>, expected: 'aaaaaaaaaa0f87d2df5e0cff356df307b6649a7b0b4effdf4b6dbd15070206de', calculated: '907f97b96e0f87d2df5e0cff356df307b6649a7b0b4effdf4b6dbd15070206de'
    info: if you are on the official release server, this is most likely due to an update happening right now, please try again later
    info: if you are on a third-party release server, this might indicate a problem with the server's configuration
    error: toolchain 'nightly-aarch64-apple-darwin' is not installable

#3885 (comment)

@rami3l rami3l requested a review from djc July 7, 2024 04:41
@rami3l rami3l force-pushed the fix/manifest-checksum-failed branch 2 times, most recently from 92dda7c to 000f1f3 Compare July 7, 2024 04:51
@rami3l rami3l changed the title feat(dist)!: refine suggestions regarding manifest checksum mismatches feat(dist): refine suggestions regarding manifest checksum mismatches Jul 7, 2024
@rami3l rami3l force-pushed the fix/manifest-checksum-failed branch from 000f1f3 to d365542 Compare July 7, 2024 11:02
djc
djc reviewed Jul 8, 2024
View reviewed changes
src/dist/notifications.rs Show resolved Hide resolved
src/dist/mod.rs Outdated Show resolved Hide resolved
@rami3l rami3l force-pushed the fix/manifest-checksum-failed branch from d365542 to 7690fc3 Compare July 8, 2024 12:10
@rami3l rami3l requested a review from djc July 8, 2024 12:15
@rami3l rami3l force-pushed the fix/manifest-checksum-failed branch 2 times, most recently from c0fefc3 to b66256c Compare July 8, 2024 12:39
@djc djc mentioned this pull request Jul 8, 2024
Merged
@rami3l rami3l force-pushed the fix/manifest-checksum-failed branch from b66256c to 00ea895 Compare July 8, 2024 14:57
djc
djc approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/dist/mod.rs Show resolved Hide resolved
@rami3l rami3l force-pushed the fix/manifest-checksum-failed branch from 00ea895 to c60bc64 Compare July 8, 2024 15:11
@rami3l rami3l enabled auto-merge July 8, 2024 15:15
@rami3l rami3l added this pull request to the merge queue Jul 8, 2024
Merged via the queue into rust-lang:master with commit 1997b58 Jul 8, 2024
27 checks passed
@rami3l rami3l deleted the fix/manifest-checksum-failed branch July 8, 2024 15:44
@rami3l rami3l mentioned this pull request Oct 6, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing error message toolchain "stable-x86_64-unknown-linux-gnu" is not installable
2 participants
@rami3l @djc