Autodetect TTY and add colors #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let e = e.as_ref().to_str().unwrap_or(""); | ||
| e == "--color" | ||
| }) | ||
| { |
There was a problem hiding this comment.
Please pull out this expression from (&args).iter() onward into a local variable with a descriptive name like, has_color_arg.
I believe this check should be e.starts_with("--color") since it could see e.g. --color=always.
|
Looks good. Thank you. |
|
Thanks for the eyeballs! Fixed those issues, test pass locally, now to wait for appveyor and travis. |
|
lgtm but the test failure is legit |
|
Should be fixed in the current commit. This is the reverse of the usual pain - I frequently fail to test on Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If *nix users are running on a tty (using the same checks as rustc & cargo), then colors will be displayed.
Windows users are still out in the cold. This could potentially be fixed by changing rustc to emit ANSI color codes on Windows 10 and newer - but that's a rustc thing, not a rustup thing.