-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue: expand CI testing #78
Comments
cc @rust-lang/infra I think we have a few repos in |
@KodrAus, @rust-lang/infra a little update: tier 2 targets are now all |
@Thomasdezeeuw I'm guessing it's more the OS than the architecture that you're interested in for the tier 2 targets? It looks like we might be able to use MacOS workers in GitHub Actions to run some of the BSDs. Alternatively, Travis CI does seem to support FreeBSD (although I can't find any docs on it), which we do still use in some repos here in |
Yes let's start with the OS. I think if we can run tests on all supported OSs, on any architecture, we can ensure the functionally works. Than
There is also https://cirrus-ci.org/ for FreeBSD, e.g. Mio uses the following file: https://github.com/tokio-rs/mio/blob/04050dbd87d7b79c33168c6a972a8bb35cf510f8/.cirrus.yml. |
Don't think there is much left to do here, so closing. |
I believe WASI can be supported since their lib-c exposes sockets. I'd be interested in adding it. |
Sounds good @jkelleyrtp. Although last I check (I think version 9/10) WASI didn't allow for the creation of sockets, however that could have changed. In either case the various socket options could still be useful. |
I would be interested in giving it a try. However, after looking a bit through the codebase, I feel that it might be somewhat complicated and not that easy at the moment.
I think that's still true, but there is an open and active proposal to add the functionality to create sockets (https://github.com/WebAssembly/wasi-sockets/blob/f2ffc745086ec7ab168f1244f2b3ef0342bf9ddc/wit/tcp-create-socket.wit#L26 and https://github.com/WebAssembly/wasi-sockets/blob/f2ffc745086ec7ab168f1244f2b3ef0342bf9ddc/wit/udp-create-socket.wit#L26) which is currently in 'Phase 3 - Implementation Phase (CG + WG)'. The proposal has been already introduced in At the time of writing, WASIX has support via I'm just a random user who stumbled upon this problem: |
Let's have the discussion in the other thread (#268 (comment)). |
CI support, following the same tiers as rust (https://doc.rust-lang.org/nightly/rustc/platform-support.html).
Tier 1
Tests must pass.
Tier 2
Must build.
Tier 3
Best effort.
Old description:
Currently only Linux, macOS and Windows are tested on the CI but we support (to some degree) many more OSes. We should add more of these OSes to the CI, at least running
cargo check
. For (Rust) tier 1 architecture/OS combos this should be easy, but for other tiersrustup
might not be supported.The text was updated successfully, but these errors were encountered: