Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assume memory layout of std::net::SocketAddr (0.3.x) #120

Merged
merged 12 commits into from
Nov 7, 2020
Merged

Don't assume memory layout of std::net::SocketAddr (0.3.x) #120

merged 12 commits into from
Nov 7, 2020

Commits on Nov 6, 2020

  1. Convert SocketAddrV* -> SockAddr safely

    @faern
    faern committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    7c25373 View commit details
    Browse the repository at this point in the history

  2. Convert SockAddr -> SocketAddrV* safely

    @faern
    faern committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    b5627a2 View commit details
    Browse the repository at this point in the history

  3. cleanup

    @faern
    faern committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    b831b44 View commit details
    Browse the repository at this point in the history

  4. Convert from SocketAddrV* to SockAddr with less copying

    @faern
    faern committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    c582e73 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2020

  1. Adapt code to different sockaddr struct impl on Windows

    @faern
    faern committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    738612a View commit details
    Browse the repository at this point in the history

  2. Get rid of mem::transmute in favor of correctly init values

    @faern
    faern committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    09eb49b View commit details
    Browse the repository at this point in the history

  3. Cleanup

    @faern
    faern committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    2c084f0 View commit details
    Browse the repository at this point in the history

  4. Replace ..mem::zeroed() with conditional real fields

    @faern
    faern committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    7cef159 View commit details
    Browse the repository at this point in the history

  5. Add safety docs to two unsafe usages

    @faern
    faern committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    487ceb5 View commit details
    Browse the repository at this point in the history

  6. Initialize sockaddr_storage to zero at all times

    @faern
    faern committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    36ea8a0 View commit details
    Browse the repository at this point in the history

  7. Remove redundant named struct field

    @faern
    faern committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    eae8c9f View commit details
    Browse the repository at this point in the history

  8. Much cleaner writing to uninitialized sockaddr_storage

    @faern
    faern committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    3c97dd4 View commit details
    Browse the repository at this point in the history