Fix TCP keepalive handling on Haiku and OpenBSD #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Haiku and OpenBSD don't call `setsockopt(fd, IPPROTO_TCP, SO_KEEPALIVE, secs)`, it is incorrect because `SO_KEEPALIVE` belongs to `SOL_SOCKET` layer, because it accepts a boolean instead of the number of seconds, and because there is no way to set keepalive idle time per socket on these operating systems. On Haiku and OpenBSD it is only possible to enable and disable keepalives, and it is already done with `setsockopt(fd, SOL_SOCKET, SO_KEEPALIVE, 1)` in a portable way in `Socket.set_keepalive()` defined in `src/socket.rs`.
|
Thanks for looking into this. Does this fix #85? |
Thomasdezeeuw
approved these changes
Jul 28, 2021
No, there are still two other test failures. |
This was referenced Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Haiku and OpenBSD don't call
setsockopt(fd, IPPROTO_TCP, SO_KEEPALIVE, secs), it is incorrect becauseSO_KEEPALIVEbelongsto
SOL_SOCKETlayer, because it accepts a boolean instead of thenumber of seconds, and because there is no way to set keepalive idle
time per socket on these operating systems.
On Haiku and OpenBSD it is only possible to enable and disable
keepalives, and it is already done with
setsockopt(fd, SOL_SOCKET, SO_KEEPALIVE, 1)in a portable way inSocket.set_keepalive()defined in
src/socket.rs.