Add: header_included_v6() and set_header_included_v6() #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
There was a problem hiding this comment.
Can we do it in the same way as #432? Add a _v4 version and deprecating the no suffix version?
jjnicola
force-pushed
the
ip-hdrincl-v6
branch
4 times, most recently
from
e824e46 to
70d2f72
Compare
Also, deprecate header_included() and set_header_included() in favor of header_included_v4() and set_header_included_v4().
Thomasdezeeuw
approved these changes
Jun 19, 2024
Comment on lines
+1169
to
+1172
| #[cfg_attr( | ||
| any(target_os = "fuchsia", target_os = "illumos", target_os = "solaris"), | ||
| allow(rustdoc::broken_intra_doc_links) | ||
| )] |
There was a problem hiding this comment.
Why is this needed?
There was a problem hiding this comment.
Oh I see it's on set_header_included_v4, hmmm.. ok to leave then for now.
Comment on lines
+1704
to
+1707
| #[cfg_attr( | ||
| any(target_os = "fuchsia", target_os = "illumos", target_os = "solaris"), | ||
| allow(rustdoc::broken_intra_doc_links) | ||
| )] |
|
Thanks @jjnicola |
|
Thanks you @Thomasdezeeuw . |
|
Hi! do you know when this will be available in the crate? |
jjnicola
added a commit
to jjnicola/socket2
that referenced
this pull request
Oct 15, 2024
Broken since rust-lang#518 - looks like BSD operating systems don't support IP_HDRINCL at the IPPROTO_IPV6 socket level like Linux and Windows; this is causing CI to fail.
jjnicola
added a commit
to jjnicola/socket2
that referenced
this pull request
Oct 15, 2024
Broken since rust-lang#518 - looks like BSD operating systems don't support IP_HDRINCL at the IPPROTO_IPV6 socket level like Linux and Windows; this is causing CI to fail.
jjnicola
added a commit
to jjnicola/socket2
that referenced
this pull request
Oct 15, 2024
Broken since rust-lang#518 - looks like BSD operating systems don't support IP_HDRINCL at the IPPROTO_IPV6 socket level like Linux and Windows; this is causing CI to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, deprecate header_included() and set_header_included() in favor of header_included_v4() and set_header_included_v4()
Close #517