Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for original_dst for windows #529

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

keithmattix
Copy link

@keithmattix keithmattix commented Sep 12, 2024

I noticed there wasn't support for original dst in Windows, so I added it. Also add windows gnu target to allow cross compiling

Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that at least Linux has SO_ORIGINAL_DST and IP6T_SO_ORIGINAL_DST as well, can we add it for it as well?

@keithmattix
Copy link
Author

@Thomasdezeeuw it's already added in the sys/unix.rs file:

pub fn original_dst(&self) -> io::Result<SockAddr> {

@Thomasdezeeuw
Copy link
Collaborator

@Thomasdezeeuw it's already added in the sys/unix.rs file:

pub fn original_dst(&self) -> io::Result<SockAddr> {

Ah, in that case it should be moved to the src/socket.rs file to ensure the API is the same across OS.

@keithmattix
Copy link
Author

Ok yeah I had that thought but wanted to confirm. Will make the change!

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@keithmattix
Copy link
Author

@Thomasdezeeuw any clue what's going on with the FreeBSD CI? From what I can tell, it looks like it's failing due to the test runners not support ipv6

src/socket.rs Outdated Show resolved Hide resolved
src/socket.rs Show resolved Hide resolved
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@keithmattix
Copy link
Author

I opened #534 to address the FreeBSD failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants