More mdbook-spec publish updates #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was not intended to be interpreted as rust code.
JoelMarcey
reviewed
Jul 5, 2024
| @@ -116,7 +116,7 @@ impl Spec { | |||
| /// | |||
| /// The blockquote should look something like: | |||
| /// | |||
| /// ``` | |||
| /// ```markdown | |||
There was a problem hiding this comment.
Ugh. I missed that. I betcha I was thinking code block, probably.
JoelMarcey
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a mistake in a comment that prevented
cargo testfrom running, and thus prevents publishing.I also forgot to update
Cargo.lockfor the version bump. I did that, and also updated all outdated dependencies.Finally, I added some steps to CI to avoid future issues.