Support panicking and make unsupported platforms a nop #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
reviewed
Nov 2, 2018
alexcrichton
reviewed
Nov 2, 2018
alexcrichton
reviewed
Nov 3, 2018
alexcrichton
reviewed
Nov 3, 2018
alexcrichton
reviewed
Nov 3, 2018
|
It looks like MSVC is having trouble with the panicking code? (MinGW on appveyor failures can probably be ignored) |
|
I'll try to find a windows machine to debug this on |
alexcrichton
reviewed
Nov 6, 2018
alexcrichton
reviewed
Nov 6, 2018
…various extern functions
…ven after popping it
|
FWIW I think a git dep in rustc should be sufficient for profiling, but if you need me to publish anything here just let me know! |
|
I've cleaned this up a bit and moved it over to https://github.com/alexcrichton/stacker/pull/11 so I'm gonna close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc rust-lang/rust#55617 (comment)