-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial code considerations and other sections #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KodrAus
changed the title
Feat/code considerations
Initial code considerations and other sections
Jan 29, 2021
The process sections are still very sparse, but we should be able to fill them out pretty well. |
m-ou-se
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looking forward to filling out all this stuff more. :)
I'll go ahead and merge this in then so we can start working on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1 and #3
This is a large drop of our existing forge docs that's been re-organized into a Code considerations section. It's got a stubbed out reviewer checklist too that we could try turn into a friendly document that reviewers can refer to when PRs come along.
I've also stubbed out a Lifecycle of a feature section where we can talk about new unstable APIs, tracking issues, stabilizations, and deprecations.
It's all still very rough 🙂 But should give us space to start capturing more code guidelines and start documenting our processes.
r? @m-ou-se @Mark-Simulacrum