Add policy detailing review procedure for target-specific code #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDenton
approved these changes
Jan 20, 2024
the8472
reviewed
Jan 20, 2024
| For tier 1 targets, the reviewer should perform a full review of the code. | ||
| Essentially treat the code as *not* platform specific. | ||
|
|
||
| For tier 2 and tier 3 targets, the reviewer should confirm that the code: |
dtolnay
reviewed
Jan 20, 2024
Comment on lines
+6
to
+9
| For tier 1 targets, the reviewer should perform a full review of the code. | ||
| Essentially treat the code as *not* platform specific. | ||
|
|
||
| For tier 2 and tier 3 targets, the reviewer should confirm that the code: |
There was a problem hiding this comment.
Briefly reiterating the platform support policy would help motivate this guidance. Something like:
For tier 1 targets, the reviewer should perform a full review of the code. Essentially treat the code as not platform specific. Tier 1 code is considered "guaranteed to work", and code review is an important aspect of how we uphold this guarantee.
Tier 2 targets are considered "guaranteed to build". When reviewing tier 2 and tier 3 target-specific code, we don't ask thorough scrutiny but the reviewer should confirm that the code:
dtolnay
approved these changes
Jan 21, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 21, 2024
generated from commit 23d4ff6
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 21, 2024
…r=dtolnay Warn users about limited review for tier 2 and 3 code Needs rust-lang/std-dev-guide#61
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 21, 2024
…r=dtolnay Warn users about limited review for tier 2 and 3 code Needs rust-lang/std-dev-guide#61
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 22, 2024
Rollup merge of rust-lang#120174 - Mark-Simulacrum:link-libs-policy, r=dtolnay Warn users about limited review for tier 2 and 3 code Needs rust-lang/std-dev-guide#61
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
Warn users about limited review for tier 2 and 3 code Needs rust-lang/std-dev-guide#61
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
Warn users about limited review for tier 2 and 3 code Needs rust-lang/std-dev-guide#61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in Zulip, including some links to applications of this in practice: https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/review.20policy.20for.20tier-3.20.28and.20tier-2.3F.29.20targets