Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we use std by default? #193

Closed
gnzlbg opened this issue Nov 17, 2017 · 3 comments
Closed

Should we use std by default? #193

gnzlbg opened this issue Nov 17, 2017 · 3 comments

Comments

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 17, 2017

Currently std is an opt-in feature, should we add it to the default features of the crate?
@gnzlbg gnzlbg mentioned this issue Nov 17, 2017
Merged
@BurntSushi
Copy link
Member

Yes. AFAIK, this is what everyone (that supports no_std and std) does. std by default, where no_std is opt-in.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 17, 2017

Ok, I'll send a PR.

gnzlbg added a commit to gnzlbg/stdsimd that referenced this issue Nov 17, 2017
@gnzlbg
enable std by default
0d43530 
Closes rust-lang#193.
gnzlbg added a commit to gnzlbg/stdsimd that referenced this issue Nov 17, 2017
@gnzlbg
enable std by default
0a8b5cd 
Closes rust-lang#193.
@gnzlbg gnzlbg mentioned this issue Nov 17, 2017
Closed
@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 22, 2017

Now stdsimd does always require std, while those in core can use coresimd instead, which is unconditionally no_std.

@gnzlbg gnzlbg closed this as completed Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BurntSushi @gnzlbg