Convert vsli_n_* neon methods to const generics #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
SparrowLii
force-pushed
the
generic_const
branch
from
d220418 to
4bd13c1
Compare
Amanieu
reviewed
Mar 1, 2021
| vsli_n_s8_(a, b, n) | ||
| #[rustc_legacy_const_generics(2)] | ||
| pub unsafe fn vsli_n_s8<const N: i32>(a: int8x8_t, b: int8x8_t) -> int8x8_t { | ||
| assert!(0 <= N && N <= 7, "must have 0 ≤ N ≤ 7, but N = {}", N); |
There was a problem hiding this comment.
Use static_assert! instead of assert!.
There was a problem hiding this comment.
Thanks for pointing. It has been corrected.
SparrowLii
force-pushed
the
generic_const
branch
from
4bd13c1 to
2a1d6b8
Compare
|
Sorry I currently only have aarch64 machines on hand, so I can't test arm and armv7 by myself. I will get them soon. |
SparrowLii
force-pushed
the
generic_const
branch
from
ee1788f to
c4ef544
Compare
|
In order to make the review easier, I split this pr into several parts |
SparrowLii
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use generic const in the following methods:
vsli_n_*
vsliq_n_*
Fixes #1017