Add vdiv neon instructions #1077
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| b = 1.0, 2.0, 1.0, 2.0 | ||
| validate 2.0, 3.0, 4.0, 5.0 | ||
|
|
||
| aarch64 = fdiv |
There was a problem hiding this comment.
Can you generate arm versions of this which use the vdiv instruction?
There was a problem hiding this comment.
Note that arm only supports f32 variants: f64 is aarch64-only.
There was a problem hiding this comment.
According to the docs the supported architectures are only A64: https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vdiv
Supported architectures
A64
Maybe the docs are wrong?
There was a problem hiding this comment.
Ah you are correct, it seems the ARM vdiv instruction only supports scalar division, not vector division.
I'm not sure if that's all there is to do. Seemed like an odd omission in the first place. Maybe I'm missing something?