Allow mapping a runtime feature to a set of target_features #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
Amanieu
pushed a commit
that referenced
this pull request
Aug 22, 2022
This allows using feature detection macros, without placing a requirement of enabled stdsimd feature gate from end users. A follow-up to changes from #1311, which introduced the new macro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that runtime features and
target_featuresare logically separate rust-lang/rust#91608, there's a need to map between the two. Usually runtime feature detection short-circuits if a matchingtarget_featureis enabled. However, onaarch64-apple-darwinthere's no backup runtime detection yet so we rely purely on this behaviour.Notably this fixes
std::arch::is_aarch64_feature_detected!("fp")returning false onaarch64-apple-darwinand allows for multipletarget_featuresto be specified in the future.