-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename misleading features #1355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
calebzulawski
force-pushed
the
misleading-features
branch
from
November 17, 2022 02:49
0fdfaf0
to
c283960
Compare
I think |
I added a deprecation warning, but the way it's emitted is admittedly a hack. It emits this reasonable message:
|
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2023
…nieu Remove misleading target feature aliases Fixes rust-lang#100752. This is a follow up to rust-lang#103750. These aliases could not be completely removed until rust-lang/stdarch#1355 landed. cc `@Amanieu`
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
May 16, 2023
Remove misleading target feature aliases Fixes #100752. This is a follow up to #103750. These aliases could not be completely removed until rust-lang/stdarch#1355 landed. cc `@Amanieu`
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 20, 2024
Remove misleading target feature aliases Fixes #100752. This is a follow up to #103750. These aliases could not be completely removed until rust-lang/stdarch#1355 landed. cc `@Amanieu`
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
Remove misleading target feature aliases Fixes #100752. This is a follow up to #103750. These aliases could not be completely removed until rust-lang/stdarch#1355 landed. cc `@Amanieu`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed features according to rust-lang/rust#100752 (and #1325)
This works on master, but rust-lang/rust#103750 hasn't hit nightly yet.landed on nightlyAn open question: in
is_x86_feature_detected
, shouldavx512gfni
be an alias forgfni
(even though it doesn't actually check foravx512f
), or should it be a separate feature that checks the multiple feature flags required to enable the AVX-512 GFNI instructions? (and the same goes foravx512vaes
andavx512vpclmulqdq
)