Resolve old FIXME comments #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rustbot has picked a reviewer for you, use r? to override) |
lu-zero
reviewed
Dec 28, 2022
| // FIXME(https://bugs.llvm.org/show_bug.cgi?id=50507) - this produces an | ||
| // extraneous `i32.and` instruction against a mask of 65535 when converting | ||
| // from the native intrinsic's i32 return value to our desired u16. This | ||
| // shouldn't be necessary, though, but requires upstream LLVM changes. |
There was a problem hiding this comment.
Maybe keep the note and mention since which version it got fixed?
There was a problem hiding this comment.
Actually I cannot find when it was fixed (before 1.54?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.