Skip to content

Don't declare f16c_target_feature. #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2023
Merged

Don't declare f16c_target_feature. #1371

merged 1 commit into from
Jan 22, 2023

Conversation

jacobbramley
Copy link
Contributor

f16c_target_feature was recently stabilised.

This fixes a warning that results in a CI failure (due to -D stable-features) with current nightly Rust.

@jacobbramley
Don't declare f16c_target_feature.
156aaea 
f16c_target_feature was recently stabilised.

This fixes a warning that results in a CI failure (due to `-D
stable-features`) with current nightly Rust.
@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2023

r? @Amanieu

(rustbot has picked a reviewer for you, use r? to override)

@jacobbramley
Copy link
Contributor Author

This fixes the CI failure in #1370. There's related work going on in #1366, but this seems different.

I'm not certain if this is the right process to fix this failure (e.g. as opposed to a fix included with some other PR), so please let me know if another approach would be better.

@Urgau Urgau mentioned this pull request Jan 19, 2023
Merged
@Amanieu Amanieu merged commit d7a8ee1 into rust-lang:master Jan 22, 2023
@Amanieu Amanieu mentioned this pull request Jan 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobbramley @rustbot @Amanieu