Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow internal_features #1394

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Allow internal_features #1394

merged 1 commit into from
Mar 19, 2023

Conversation

Noratrieb
Copy link
Member

I'm writing the lint, so it needs to be allowed here.
Needs to wait on rust-lang/compiler-team#596

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

@Noratrieb Noratrieb marked this pull request as draft March 19, 2023 15:17
@Noratrieb
Copy link
Member Author

Waiting for the rustc PR to be merged and being updated here, you might need to add the allow() when updating it. I'll keep this open for now to remind myself to check back later and remove the hacks.

@Noratrieb Noratrieb marked this pull request as ready for review March 19, 2023 20:11
@Noratrieb
Copy link
Member Author

I think I actually need to do it this way through here. Adding an -Ainternal_features in bootstrap sounded nice but doesn't work with other tools that build a sysroot and fixing them is way more effort than just adding the allow here. We do sadly have to allow(unknown_lints), but I'll open an issue and assign myself to remove it again as soon as possible.

@Amanieu this is ready now

CI seems to be having a weird day.....

@Amanieu
Copy link
Member

Amanieu commented Mar 19, 2023

This is due to rust-lang/rust#107224 which upgraded rustc to LLVM 16.

@Noratrieb
Copy link
Member Author

Noratrieb commented Mar 19, 2023

So we need to wait until the revert lands in nightly or whatever is used here?

@Amanieu Amanieu merged commit b655243 into rust-lang:master Mar 19, 2023
@Amanieu
Copy link
Member

Amanieu commented Mar 19, 2023

It's fine to force a merge for now, since this is a fairly straightforward change. This often happens when changes need to be done to both rustc and stdarch at the same time, but it's something that we're working towards a solution for.

@Noratrieb Noratrieb deleted the we-use-internal-features-and-its-good branch March 19, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants