Skip to content

Split the stdsimd feature into separate features #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Oct 29, 2023
Merged

Split the stdsimd feature into separate features #1486

merged 28 commits into from
Oct 29, 2023

Conversation

@Amanieu
Copy link
Member

@Amanieu Amanieu commented Oct 26, 2023

More importantly, each feature now gets its own tracking issue, which should help towards eventual stabilization.

New tracking issues:

Amanieu added 26 commits October 26, 2023 18:12
@Amanieu
Add tracking issue for AVX-512
6fb2ab0
@Amanieu
Add tracking issue for RTM
d944d8f
@Amanieu
Add stability attributes on x86 re-exports
981b44e
@Amanieu
Add tracking issue on has_cpuid
80016b6
@Amanieu
Revert accidental stabilization of _mm512_storeu_ps
7c90f9c
@Amanieu
Add tracking issue for RISC-V intrinsics
15c59a6
@Amanieu
Add tracking issue for PowerPC intrinsics
ba272a3
@Amanieu
Check for missing stability attributes when building outside core
41cc0f1
@Amanieu
Add tracking issue for _MM_SHUFFLE
ba9fbfa
@Amanieu
Add tracking issues for WebAssembly
4ea3fe3
@Amanieu
Add tracking issue for MIPS intrinsics
63a19fd
@Amanieu
Add tracking issues for feature detection
0121a7d
@Amanieu
Add tracking issue for NVPTX intrinsics
9e839f6
@Amanieu
Add tracking issue for ARM NEON instructions
771cfa0
@Amanieu
Fix stability attributes for ARM crypto intrinsics
c297556
@Amanieu
Fix 'since' in simd_avx512_types stability attribute
47ef0a2
@Amanieu
Add stability attributes for re-exports of AArch64 NEON intrinsics
c08c928
@Amanieu
Add tracking issue for ARM CRC32 intrinsics
02d3d32
@Amanieu
Add tracking issue for AArch64 TME intrinsics
ddd9df8
@Amanieu
Add tracking issue for AArch64 prefetch intrinsic
7b7046b
@Amanieu
Add tracking issue for ARM hint intrinsics
257fea9
@Amanieu
Add tracking issue for ARM barrier intrinsics
23ccc91
@Amanieu
Add tracking issue for all remaining unstable NEON intrinsics
623305c
@Amanieu
Remove ARM udf and dbg intrinsics
60ea44f 
These have already been removed for AArch64
@Amanieu
Add tracking issue for 32-bit ARM DSP instrinsics
0708bdf
@Amanieu
Cleanup last uses of the stdsimd feature
ff24118
@rustbot
Copy link
Collaborator

rustbot commented Oct 26, 2023

@Amanieu: no appropriate reviewer found, use r? to override

@Amanieu Amanieu force-pushed the tracking-issues branch 2 times, most recently from 4fc3a6c to 48876ef Compare October 28, 2023 01:38
Amanieu added a commit that referenced this pull request Jan 4, 2024
@Amanieu
Fix std build failure on non-x86 architectures
10b0fcd 
This is more fallout from #1486
Amanieu added a commit to Amanieu/stdarch that referenced this pull request Jan 4, 2024
@Amanieu
Fix std_detect not being an unstable crate
f0a4b09 
More fallout from rust-lang#1486
@Amanieu Amanieu mentioned this pull request Jan 4, 2024
Merged
Amanieu added a commit to Amanieu/stdarch that referenced this pull request Jan 4, 2024
@Amanieu
Fix std_detect not being an unstable crate
02fd895 
More fallout from rust-lang#1486
Amanieu added a commit to Amanieu/stdarch that referenced this pull request Jan 4, 2024
@Amanieu
Fix std_detect not being an unstable crate
bb746c6 
More fallout from rust-lang#1486
Amanieu added a commit to Amanieu/stdarch that referenced this pull request Jan 4, 2024
@Amanieu
Fix std_detect not being an unstable crate
54d0be0 
More fallout from rust-lang#1486
Amanieu added a commit to Amanieu/stdarch that referenced this pull request Jan 5, 2024
@Amanieu
Fix std_detect not being an unstable crate
0bb02ee 
More fallout from rust-lang#1486
Amanieu added a commit to Amanieu/stdarch that referenced this pull request Jan 5, 2024
@Amanieu
Fix std_detect not being an unstable crate
fdccdb1 
More fallout from rust-lang#1486
Amanieu added a commit to Amanieu/stdarch that referenced this pull request Jan 5, 2024
@Amanieu
Fix std_detect not being an unstable crate
6fd7679 
More fallout from rust-lang#1486
Amanieu added a commit that referenced this pull request Jan 5, 2024
@Amanieu
Fix std_detect not being an unstable crate
5ef6eb4 
More fallout from #1486
@jimmygchen jimmygchen mentioned this pull request Feb 6, 2024
Merged
@robinhundt robinhundt mentioned this pull request Feb 6, 2024
Merged
@RalfJung
Copy link
Member

RalfJung commented Feb 9, 2024

This patch turns out to be quite painful: rust-lang/portable-simd#389

@Amanieu
Copy link
Member Author

Amanieu commented Feb 11, 2024

Unfortunately it is necessary to properly track all of the stdarch features. Perhaps this is something that can be addressed at the compiler level?

@RalfJung RalfJung mentioned this pull request Feb 11, 2024
Open
@RalfJung
Copy link
Member

Filed a rustc issue: rust-lang/rust#120930

@burdges burdges mentioned this pull request Feb 12, 2024
Closed
2 tasks
@lazyky lazyky mentioned this pull request Feb 20, 2024
Merged
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 5, 2024
@jrmuizel
Bug 1882291. Switch to stdarch_arm_neon_intrinsics feature on rust >=…
73676e6 
…1.78. r=glandium

We only need this on ARM32 because the ARM64 intrinsics are stable.

stdarch_arm_neon_intrinsics was split out from stdsimd here:
rust-lang/stdarch#1486

Differential Revision: https://phabricator.services.mozilla.com/D203039
moz-gfx pushed a commit to moz-gfx/qcms that referenced this pull request Mar 5, 2024
@jrmuizel
Bug 1882291. Switch to stdarch_arm_neon_intrinsics feature on rust >=…
4c8ad99 
…1.78. r=glandium

We only need this on ARM32 because the ARM64 intrinsics are stable.

stdarch_arm_neon_intrinsics was split out from stdsimd here:
rust-lang/stdarch#1486

Differential Revision: https://phabricator.services.mozilla.com/D203039

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/e9b01ce8e2fe053ffef77505f05cf18ed0b9fcd2
@tchataigner tchataigner mentioned this pull request Mar 22, 2024
Open
MrAlex94 pushed a commit to BrowserWorks/waterfox that referenced this pull request May 13, 2024
@jrmuizel @MrAlex94
Bug 1882291. Switch to stdarch_arm_neon_intrinsics feature on rust >=…
01fe038 
…1.78. r=glandium

We only need this on ARM32 because the ARM64 intrinsics are stable.

stdarch_arm_neon_intrinsics was split out from stdsimd here:
rust-lang/stdarch#1486

Differential Revision: https://phabricator.services.mozilla.com/D203039
MrAlex94 pushed a commit to BrowserWorks/waterfox that referenced this pull request May 13, 2024
@jrmuizel @MrAlex94
Bug 1882291. Switch to stdarch_arm_neon_intrinsics feature on rust >=…
76cda0c 
…1.78. r=glandium

We only need this on ARM32 because the ARM64 intrinsics are stable.

stdarch_arm_neon_intrinsics was split out from stdsimd here:
rust-lang/stdarch#1486

Differential Revision: https://phabricator.services.mozilla.com/D203039
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 24, 2024
@jrmuizel
Bug 1882291. Switch to stdarch_arm_neon_intrinsics feature on rust >=…
a7cb409 
…1.78. r=glandium a=RyanVM

We only need this on ARM32 because the ARM64 intrinsics are stable.

stdarch_arm_neon_intrinsics was split out from stdsimd here:
rust-lang/stdarch#1486

Differential Revision: https://phabricator.services.mozilla.com/D203039
github-actions bot pushed a commit to Floorp-Projects/Floorp that referenced this pull request Jun 11, 2024
@jrmuizel
Bug 1882291. Switch to stdarch_arm_neon_intrinsics feature on rust >=…
ef1db91 
…1.78. r=glandium a=RyanVM

We only need this on ARM32 because the ARM64 intrinsics are stable.

stdarch_arm_neon_intrinsics was split out from stdsimd here:
rust-lang/stdarch#1486

Differential Revision: https://phabricator.services.mozilla.com/D203039
@diogotcorreia diogotcorreia mentioned this pull request Jun 16, 2024
Closed
@workingjubilee workingjubilee mentioned this pull request Jun 20, 2024
Closed
2 tasks
Ponchale added a commit to goastian/midori-desktop that referenced this pull request Aug 9, 2024
@Ponchale
Bug 1882291. Switch to stdarch_arm_neon_intrinsics feature on rust >=…
e086ed2 
…1.78. r=glandium a=RyanVM

We only need this on ARM32 because the ARM64 intrinsics are stable.

stdarch_arm_neon_intrinsics was split out from stdsimd here:
rust-lang/stdarch#1486

Differential Revision: https://phabricator.services.mozilla.com/D203039
glandium pushed a commit to mozilla-firefox/firefox that referenced this pull request Mar 11, 2025
@jrmuizel
Bug 1882291. Switch to stdarch_arm_neon_intrinsics feature on rust >=…
c6bb853 
…1.78. r=glandium a=RyanVM

We only need this on ARM32 because the ARM64 intrinsics are stable.

stdarch_arm_neon_intrinsics was split out from stdsimd here:
rust-lang/stdarch#1486

Differential Revision: https://phabricator.services.mozilla.com/D203039
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
@jrmuizel
Bug 1882291. Switch to stdarch_arm_neon_intrinsics feature on rust >=…
50b3352 
…1.78. r=glandium

We only need this on ARM32 because the ARM64 intrinsics are stable.

stdarch_arm_neon_intrinsics was split out from stdsimd here:
rust-lang/stdarch#1486

Differential Revision: https://phabricator.services.mozilla.com/D203039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Amanieu @rustbot @RalfJung