Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import LLVM SIMD intrinsics from core rather than declaring them locally #1529

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

RalfJung
Copy link
Member

These intrinsics are very tied to rustc so it's nicer to have them in the same repo as rustc. This also lets us share the definitions with portable-simd.

However it turns out some intrinsics are still missing on the rustc side, I will add them there. Also some intrinsics seem to be entirely unused:

  • simd_reduce_min_nanless
  • simd_reduce_max_nanless
  • simd_fsin
  • simd_fcos
  • simd_fexp
  • simd_fexp2
  • simd_flog10
  • simd_flog2
  • simd_flog

@rustbot
Copy link
Collaborator

rustbot commented Feb 17, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Amanieu Amanieu merged commit 4d9c0bb into rust-lang:master Feb 17, 2024
27 checks passed
@RalfJung RalfJung deleted the simd_llvm branch February 17, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants