Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std_detect: Use elf_aux_info on FreeBSD #1640

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Sep 15, 2024

elf_aux_info is a function that does the equivalent of our current sysctl-based archauxv, available in on FreeBSD 12.0+ (freebsd/freebsd-src@0b08ae2) and 11.4+ (backport by freebsd/freebsd-src@03444a7).

FreeBSD 11 support in std has been removed in Rust 1.75 (rust-lang/rust#114521), so we can safely use this function.

(By the way, not directly related to this PR, but OpenBSD will provide the same function in the next release (7.6): openbsd/src@ef873df)

Tested on powerpc64/powerpc64le FreeBSD 14.

@rustbot
Copy link
Collaborator

rustbot commented Sep 15, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Amanieu Amanieu merged commit 17d2b18 into rust-lang:master Sep 18, 2024
33 checks passed
@taiki-e taiki-e deleted the std-detect-freebsd branch September 18, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants